On Mon, 2009-03-30 at 13:50 +0200, Jan Safranek wrote:
> Magnus Fromreide wrote:
> > On Thu, Mar 26, 2009 at 11:10:24AM +0900, Mitsuru Chinen wrote:
> >> Hi Thomas,
> >>
> >> What kind of Linux distribution are you using?
> > 
> > I supppose he is using a linux distribution with a libc version lower than
> > 2.4 - at a guess RHEL4 is one of those.
> > 
> > For glibc 2.4 MLD_LISTENER_QUERY changed name from ICMP6_MEMBERSHIP_QUERY.
> > For glibc 2.0.99 ICMP6_MEMBERSHIP_QUERY changed name from ICMPV6_MGM_QUERY.
> > ICMPV6_MGM_QUERY was never in any released glibc.
> > 
> > I think you need a configure check to verify that MLD_LISTENER_QUERY exists.
> 
> I am not good at autoconf, could you please check attached patch? After 
> 'autoheader && autoconf' it creates expected result and it's compilable 
> on RHEL4 and current Fedora. I am not if config_os_misc4 is the right 
> file to modify.

I think it seems ok but it all tured out rather ugly.

> Maybe plain #ifdef checks in icmp.c would be more readable, the MLD_ 
> macros are used only there...

I think you are right - #ifdef checks in icmp.c is more readable and
keeps the change more localized, I'd say to go for that.

/MF


------------------------------------------------------------------------------
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to