>>>>> On Mon, 17 Aug 2009 20:24:36 +0100, Dave Shield 
>>>>> <[email protected]> said:

DS> Question:  is it worth applying this immediately so that
DS> it can be included in the 5.5 release, or should we wait?

I think it's worth fixing.  But I think there is a problem with the
current patch.  I think one lock needs to be used around the whole
section of code because right now if two threads managed to get by the
first lock set at the same time they'd end up both using reqid 2 at the
end of the function, which would be bad bad bad.

I think instead the unlock from the top should be simply moved to just
above the return.  It's a longer lock, but the only way to do it safely.
-- 
Wes Hardaker
Please mail all replies to [email protected]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to