Hi,

thanks for polite warning that we have 5.5 freeze, I was not aware about it.
But I still want to fix some bugs, so let's try the official way :). According
to the freeze policy I send here small patch, which fixes endless loop in
Linux implementation of ipDefaultRouterTable in current trunk (5.5-pre1).
I think the bug is pretty serious and I'd like to have the patch in official
net-snmp-5.5.

Linux reads the routing table from kernel via netlink socket and processes
its entries in a loop. If the machine is configured with two same default
routes, CONTAINER_INSERT in defaultrouter_linux.c:299 may fail. The loop then
does not advance to next route, but continues with the already processed route
instead and CONTAINER_INSERT fails again and the same route is processed again
and again.

This patch advances to the next route from netlink if CONTAINER_INSERT
fails.

Signed-off-by: Jan Safranek <[email protected]>
---

 .../ip-mib/data_access/defaultrouter_linux.c       |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net-snmp/agent/mibgroup/ip-mib/data_access/defaultrouter_linux.c 
b/net-snmp/agent/mibgroup/ip-mib/data_access/defaultrouter_linux.c
index 05cb1b6..702128b 100644
--- a/net-snmp/agent/mibgroup/ip-mib/data_access/defaultrouter_linux.c
+++ b/net-snmp/agent/mibgroup/ip-mib/data_access/defaultrouter_linux.c
@@ -302,7 +302,6 @@ _load(netsnmp_container *container)
                                 "error with defaultrouter_entry: "
                                 "insert into container failed.\n"));
                     netsnmp_access_defaultrouter_entry_free(entry);
-                    continue;
                 }
             }
 


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to