2009/8/26 Jan Safranek <[email protected]>: > While testing net-snmp-rc1 I have noticed C++ packages (like tog-pegasus) > do not like include/net-snmp/library/types.h. > > The file contains closing brace for the C++ guard, but not the opening one, > so I'd suggest to add one in this patch.
My fault - sorry. > The C++ guard is not needed at > all, there is no function declared in the header file, but I noticed it's > common practice here. It's definitely sensible to fix this - particularly since we'll be rolling another rcN release anyway. Though I'd be reluctant to have this be the only change in a release candidate. It probably doesn't matter whether we add the opening brace, or remove the closing one. But including them is probably marginally safer (in case function definitions get added to this file at a later date). +1 (assuming this makes it in time for rc2) > Please note I explicitly did not fix coding style of the file, I think it > should be separated from this fix. That's probably due to this code being pasted directly from another (more structured) header file. I wouldn't have re-formatted the new header, on the principle of changing as little as possible at any one time. > Let me know if I shall tidy up the whitespaces. Long term, probably yes. At this point - no. Code layout issues aren't really release-blockers. I'd say leave this sort of thing until after 5.5 is out. Dave ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
