2009/11/27 Magnus Fromreide <[email protected]>: > As a result of making the oid's in agent_trap static the function > init_traps have been reduced to > > void > init_traps(void) > { > } > > so I thought I should try to remove it at some time in the future. > > Is the attached patch a good way to do that? > If not then how should one go about removing a public symbol?
My gut reaction is why bother? It's not exactly a major overhead, and removing this might break existing code. What harm is there in leaving this dummy routine in place? (It also leaves open the possibility of adding some initialisation in the future, if this becomes desirable). > On a similar note there are some oid symbols in agent_trap.c that are > unused by us that I do intend to remove. Here the question also is how > to do the removal - my current thought is to just remove them since they > lack a corresponding _len symbol. I've got more sympathy with that proposal - particularly if they are "incomplete" definitions, and hence harder to use in external code anyway. Dave ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
