On Tue, 16 Mar 2010 15:53:42 +0100 Bart wrote: BVA> On Tue, Mar 16, 2010 at 2:36 PM, Jan Safranek <jsafr...@redhat.com> wrote: BVA> > Based on yesterday's conversation, I prepared a patch with solution #2 BVA> > (put it inside asn_parse_foo (which may not be possible)). My simple BVA> > tests show that it works, see patch tracker for details: BVA> > https://sourceforge.net/tracker/?func=detail&aid=2971270&group_id=12694&atid=312694 BVA> BVA> There might be code outside the Net-SNMP source tree that e.g. parses BVA> the type ASN_COUNTER via asn_parse_int(). This works with the current BVA> implementation but will stop working if your patch would be applied. BVA> So this patch is a backwards-incompatible change.
IMHO, bug fixes trump backwards compatibility. We could check for the unsigned types and log a warning (maybe using NETSNMP_LOGONCE) pointing them at the correct function. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
