On 14 April 2010 17:52, Bart Van Assche <[email protected]> wrote:
> Hello Dave,
>
> Why did you disable the preprocessor symbol
> USING_NOTIFICATION_LOG_MIB_NOTIFICATION_LOG_MODULE
> in the file win32/net-snmp/agent/mib_module_config.h ?
> There was no agreement about this change.
My apologies.
I'd submitted a CFV that included this particular change,
and believed that this had received the necessary +3 vote
(two explicit votes from Wes and Thomas,
an implicit expression of support from you,
dated 13 April 2010 14:06
plus the automatic +1 from the patch proposer)
I'm not trying to steamroller this through - at the point when I
applied the change, I wasn't aware that there were any issues
with it.
> Another note about the same revision: why did you change
> /* #undef NETSNMP_USE_DLL */ into #define NETSNMP_USE_DLL 1 ?
> I assume that this was an accidental commit after having
> run build.bat with DLL-support enabled ?
Basically, yes.
I'd been trying various build configurations to try and fix things
in as many areas as possible. One of those was obviously
enabling DLL-support.
Whether I hadn't noticed that this setting had found its way
into the 5.4.x net-snmp-config.h file, or whether I thought it
didn't matter (since this would be re-generated from the
net-snmp-config.h.in file anyway) - I really wouldn't like to say.
It's been a busy couple of days!
Feel free to reverse these settings if you think it's necessary.
Dave
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
