On Sat, Sep 4, 2010 at 4:53 PM, Wes Hardaker <
harda...@users.sourceforge.net> wrote:
>
> (note to Bart: we're in "voting mode" for release candidates on the
> trunk right now. Which means no one should be touching trunk without
> discussion -coders first please. Thanks!)
>
> Bart already applied this patches which means:
>
> 1) if it doesn't get +3 it will be reverted
>
How many changes have you committed after rc1 and that did not get a +3 ?
2) we need to decide if it's worth it to publish a rc3 because of it
> (and another):
>
> However the patch gets +1 for me, though I probably wouldn't hold up 5.6
> for it just to do another rc3. It's safe enough to go straight to final
> with it, IMHO.
>
> --- trunk/net-snmp/agent/mibgroup/mibII/system_mib.c 2010/09/04 03:09:45
> 19370
> +++ trunk/net-snmp/agent/mibgroup/mibII/system_mib.c 2010/09/04 06:37:23
> 19371
> @@ -168,7 +168,7 @@
> static void
> system_parse_config_sysObjectID(const char *token, char *cptr)
> {
> - int sysObjectIDLength = MAX_OID_LEN;
> + size_t sysObjectIDLength = MAX_OID_LEN;
> if (!read_objid(cptr, sysObjectID, &sysObjectIDLength)) {
> netsnmp_config_error("sysobjectid token not a parsable OID:\n\t%s",
> cptr);
>
You forgot to mention the commit message:
r19371 | bvassche | 2010-09-04 08:37:23 +0200 (Sat, 04 Sep 2010) | 4 lines
>
> Fixed a compiler warning that was introduced in r19322 (patch 3044512).
> The third argument passed to read_objid() was an int instead of size_t.
> This could have caused memory corruption on 64-bit systems.
>
Bart.
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
