On Sun, Oct 17, 2010 at 10:30 AM, Magnus Fromreide <[email protected]>wrote:
> [ ... ]
>
> At the very least it is MSVC that should be treated specially and not
> GCC, why do you have an
>
> #if defined(__GNUC__)
>
> to handle windows oddities?
>
That was implemented that way because you changed uintptr_t into unsigned
long for GCC only in r18052.
> > Regarding including <inttypes.h>: please also keep in mind that the
> > header <net-snmp/library/tools.h> is already used in some configure
> > tests before net-snmp-config.h has been generated.
>
> Which ones? Remember that all the defines are added incrementally while
> configure runs so it is just an issue of making sure that the tests are
> done in the right order.
>
> > Which means: before configure had a chance to define macros like
> > HAVE_INTTYPES_H.
> >
> > Regarding Solaris 10 + Sun C 5.7: specifying "breaks builds" without
> > any further information is not very helpful.
>
> Sorry.
>
> "../../net-snmp/include/net-snmp/library/tools.h", line 83: zero-sized
> struct/union
>
> > While ANSI C allows to leave out the variable name when declaring a
> > bitfield, maybe the Sun C 5.7 compiler doesn't support this. Does
> > changing "int:-!" into "int dummy:-!" help ?
>
> No.
>
> "../../net-snmp/include/net-snmp/library/tools.h", line 83: zero sized
> bit-field
> "../../net-snmp/include/net-snmp/library/tools.h", line 83: zero-sized
> struct/union
>
> Oh, by the way, you introduce a pedwarning in gcc as well.
>
> include/net-snmp/library/tools.h:83:14: warning: struct has no named
> members [-pedantic]
>
> That one i think should be fixed by your suggested patch.
>
All the above comments should have been addressed in r19476.
Bart.
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
