Hi Dave, thanks, you are right. I merged more than needed.
On the other site, the sparse table handling on net-snmp v5.6 works. Without my changes at the table_dataset.c. But I have no Idea why? So I merged all this files ... without luck. Later I found the solution for this problem at the table_dataset.c. First, I need a working v5.4.3 version! But want to have the notificationLogMib working on SVN trunk too. How to write a patch on the trunk for a BUG on an old release branch? Claus On 26.10.2010, at 09:48, Dave Shield wrote: > On 25 October 2010 22:30, Claus Klein <[email protected]> > wrote: >> First of all, the sparse table handling for the notificationLogMib >> does not >> work! >> >> Second the v1 trap pdu is different from the v2/v3 trap pdu. >> >> Than there are a lot of small BUGs about the trap handling toward the >> notificationLogMib. > > >> Please apply this patch and check the result about my FIXME notes. > > > I've just had a very quick look at your patch. > What immediately springs out is that it seems to include > a number of other changes, as well as the bug fixes. > (oid -> const oid, moving the initialisation of length variables, > changes to debugging output, etc) > > I got about 10% of the way through before coming across the first > possibly significant change (memdup -> snmp_duplicate_objid) > And even here, it's not immediately clear to me whether this is > fixing an actual bug, or simply a different approach. > > It's much easier to check patches if they're kept as tight as > possible. > I.e. *just* the changes needed for addressing a particular (single) > bug. > Such patches are more likely to be accepted quickly, compared to ones > where we need to unpick what is happening. > > It also helps when applying the fix across all active branches. > The larger the scope of the changes, the more likely the patch will > run into code differences between the branches. > > If you've got a cleaner version of the patch (ideally separate patches > for each of the bugs you have identified), that would really help a > lot. > > Dave ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
