Hi Niels, you are right, it works now too without that patch. But I think at least a comment would be clearer what this magic OID calculation does.
As I started searching the missing NotificationId I was wondering about that magic numbers. With my little cosmetic, and perhaps a note about the corresponding RFC section, it would be clearer, or not? By the way, added 3 test scripts to my patch, but they are not yet added to the SVN? $ svn status testing ? testing/fulltests/default/T058agentauthtrap1_simple ? testing/fulltests/default/T058agentauthtrap3_simple ? testing/fulltests/default/T058agentauthtrap2_simple $ svn info Pfad: . URL: https://net-snmp.svn.sourceforge.net/svnroot/net-snmp/trunk/net-snmp Basis des Projektarchivs: https://net-snmp.svn.sourceforge.net/svnroot/net-snmp UUID des Projektarchivs: 06827809-a52a-0410-b366-d66718629ded Revision: 19663 Knotentyp: Verzeichnis Plan: normal Letzter Autor: nba Letzte geänderte Rev: 19663 Letztes Änderungsdatum: 2010-11-11 23:48:37 +0100 (Do, 11. Nov 2010) With regards, Claus On 13.11.2010, at 13:41, Niels Baggesen wrote: > Den 11-11-2010 06:20, Claus Klein skrev: >> I am interesting in to use the NotificationLogMib, but it is still >> not >> correct filled for snmpV1 taps. >> According to the RFC, see >> http://rfc-ref.org/RFC-TEXTS/3584/chapter3.html#sub1 >> it should be like my diff >> >> Please fix it and integrate my tests scripts to check this issue. >> see >> https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3096725&group_id=12694 >> <https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3096725&group_id=12694 >> >> > > > Hi Claus, > > I think I have fixed the problem with the notification mib, but I > dont't quite see the purpose of your attached patch? Isn't it purely > cosmetic? > > /Niels > > -- > Niels Baggesen - @home - Århus - Denmark - [email protected] > The purpose of computing is insight, not numbers --- R W Hamming ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
