On Sat, 2010-12-11 at 19:07 -0500, Bill Fenner wrote: > I would like to request that the prototypes for > > void debug_print_registered_tokens(void);
I do think debug_print_registered_tokens is a tad to specialized, a public function to dump the set of currently active and actively inactive debug symbols to the log file? On the other hand it is better than accessing the dbg_tokens array directly. 0 for this change. > int debug_enable_token_logs(const char *); > int debug_disable_token_logs(const char *); For these two I agree with Wes, add netsnmp_ prefixes but +1 with that change. > be exposed in a net-snmp header file. I realize they were probably > put there for use from gdb, but in our system we already have an RPC > interface to our processes that are acting as agentx subagents, so I > added wrappers for these (along with debug_register_tokens and > snmp_set_do_debugging) to allow for interactive configuration of > debugging. This functionality is already exposed using SNMP. > For now, I'm taking the risk of putting the prototypes in the code > that's making the calls. What do people think about making this part > of the library's defined API? I dislike it. On the other hand I do not see any big changes there save for the addition of netsnmp_ prefixes. /MF ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
