On Fri, 2012-02-03 at 14:47 +0100, Bart Van Assche wrote:
> It is known that backwards and forwards adjustments of the system
> clock can cause snmpd and libsnmp to behave different than documented.
> The patch below addresses this. Because of the impact of this patch
> (it changes the ABI somewhat by storing monotonic clock values instead
> of wall clock times in some struct members) I'm posting it here as an
> RFC.

Initial impressions:

      * netsnmp_get_agent_runtime() is a good idea. I think that should
        be added regardless of the rest of the patch. 
      * I dislike that netsnmp_get_monotonic_clock might return
        gettimeofday but I suppose that there isn't much to do about
        that but maybe it is possible to get a better name for the
        function? One could do heroics with clock and assume that
        machines that lack clock_gettime have a stable clock tick but I
        do not think it isn't worth the effort.

Was there any uses of gettimeofday that were looking for absolute time
as opposed to the relative time that CLOCK_MONOTONIC represents?

/MF


------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to