On Thu, Oct 23, 2014 at 9:05 AM, Michael Bunk <m...@computer-leipzig.com> wrote:
> > As with most open source projects, committers get more and fewer cycles > to > > look at contributions. We're trying to make an effort in the next couple > > of months to get the queue down. > > Despite understanding your reasoning and life in open source projects, we > are still bothered by our impatience... is there anything we can do to > help, to reduce the prospect of months to weeks? > One thing that would help me would be to include a test case in the patch or bug report - not just "when I do X then Y then Z snmpd crashes/leaks memory/behaves incorrectly" but a script written within the net-snmp test infrastructure. (net-snmp test infrastructure? what's that?) -- look in the testing/fulltests/ subdirectory. E.g., most of the scripts in the default/ subdirectory are about 30 lines long and actually manage to test something. If you can write a test that verifies your desired result, you make it easier for the person looking at your patch to test it, with the additional benefit that the test can live in the tests directory and prevent someone from accidentally breaking it in the future. Maybe I should read the RFCs and review patches, which on the other hand > will not take any less time :) > Something that might take less time is to *try* patches, say "I had this problem, tried this patch and my problem went away too". My biggest problem when trying to decide what to do with a patch is to figure out if it breaks something else, especially if it's subtle. E.g., "I free this memory here because it leaks otherwise", without being completely familiar with the code, scares me. What if that pointer sometimes points to allocated memory and sometimes points to something longer-lived? That means that the API is wrong (or is being used incorrectly), and the right fix is to find the buggy users, not change the API. Bill
------------------------------------------------------------------------------
_______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
