On 11/15/16 09:59, Robert Story wrote:
> The branch, master has been updated
> f629d1224e2272cb6f86dbe9bea4c88aec7e8f92 ->
> 734f85551926234633a28cc6bc857e9fe2f509eb
>
> commit f629d1224e2272cb6f86dbe9bea4c88aec7e8f92
> Author: Robert Story <[email protected]>
> Date: Tue Nov 15 12:58:11 2016 -0500
>
> better handling of pdu max message size; now per packet, not per session
>
> - add msgMaxSize to snmp_pdu struct
> - defaults to SNMP_MAX_MESSAGE_LEN, then shrunk as needed for transport
> max, incoming pdu max and user configured max
> - new netsnmp_max_send_msg_size() should be used to query user
> configured max. returns SNMP_MAX_PACKET_LEN if not set, and
> SNMP_MIN_MAX_LEN if configured value is less that required min (484)
> - add some missing snmp_sess_init calls
> - snmp_sess_add_ex now returns an error if session rcvMsgMaxSize and
> sndMsgMaxSize are not set.
>
> commit 4494781070001b37d03236b73479f43cab6e3e7b
> Author: Robert Story <[email protected]>
> Date: Mon Nov 14 17:36:40 2016 -0500
>
> only use one 'max packet size' constant (SNMP_MAX_PACKET_LEN)
Hello Robert,
Can you clarify how you test your Net-SNMP changes? Patch "only use one
'max packet size' constant" breaks the build:
snmp_api.c: In function 'snmpv3_parse':
snmp_api.c:3775:19: error: 'netsnmp_pdu {aka struct snmp_pdu}' has no
member named 'msgMaxSize'
} else if (pdu->msgMaxSize > SNMP_MAX_PACKET_LEN) {
^~
Apparently that build failure has been fixed in commit "better handling
of pdu max message size; now per packet, not per session". However,
since that commit all Perl regression tests fail:
make[1]: Entering directory 'perl/SNMP'
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM"
"-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0,
'../blib/lib', '../blib/arch')" t/*.t
Can't call method "get" on an undefined value at t/async.t line 45.
t/async.t .........
Dubious, test returned 1 (wstat 256, 0x100)
Failed 20/20 subtests
# Failed test 1 in t/bulkwalk.t at line 42
# t/bulkwalk.t line 42 is: ok(defined($s1));
Can't call method "bulkwalk" on an undefined value at t/bulkwalk.t line 53.
t/bulkwalk.t ......
Dubious, test returned 1 (wstat 256, 0x100)
Failed 62/62 subtests
t/conf.t .......... ok
Can't call method "get" on an undefined value at t/dump-session.t line 27.
t/dump-session.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
[ ... ]
Bart.
------------------------------------------------------------------------------
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
