Manuel Bouyer <[email protected]> wrote: > On Thu, Aug 08, 2013 at 11:09:12AM +0100, Patrick Welche wrote: > >> One of the hunks of XSA-55 which I am trying to apply to xenkernel42 is: >> >> --- a/xen/include/xen/libelf.h >> +++ b/xen/include/xen/libelf.h >> @@ -29,6 +29,11 @@ >> #error define architectural endianness >> #endif >> >> +#include <stdbool.h> >> + >> +typedef int elf_errorstatus; /* 0: ok; -ve (normally -1): error */ >> +typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */ >> + >> #undef ELFSIZE >> #include "elfstructs.h" >> #ifdef __XEN__ >> >> $ ls -l /usr/include/stdbool.h >> -r--r--r-- 1 root wheel 1784 Apr 29 17:46 /usr/include/stdbool.h >> >> and the beginning of the long compiler line copied below contains >> -I/usr/include (as well as -nostdinc), so why do I see >> >> In file included from libelf-private.h:25:0, >> from libelf-tools.c:19: >> /tmp/pkgsrc/sysutils/xenkernel42/work.x86_64/xen-4.2.2/xen/include/xen/libelf.h:32:21: >> fatal error: stdbool.h: No such file or directory >> compilation terminated. >> >> ? (This is on -current/amd64) > > I guess it's because the -I/usr/include is after the -nostdinc > > Is stdbool.h really needed here ? AFAIK the build of the elf kernel > should not rely on host includes, only its own includes.
<sys/types.h> defines bool/true/false for the kernel -uwe
