Thanks for the write-up. I will also go through my tests again under JDK10.
Josh Juneau juneau...@gmail.com http://jj-blogger.blogspot.com https://www.apress.com/index.php/author/author/view/id/1866 > On Mar 31, 2018, at 10:54 AM, Glenn Holmer <ce...@kolabnow.com> wrote: > >> On 03/31/2018 08:50 AM, Glenn Holmer wrote: >>> On 03/31/2018 01:17 AM, Jan Lahoda wrote: >>> I've just sent: >>> https://github.com/apache/incubator-netbeans/pull/473 >>> >>> But I am not a profiler expert, so it would be, I think, helpful if >>> someone could try the patch. >> >> I've successfully cloned and built the NetBeans source; how do I apply >> this patch to my local copy? > > I figured it out (more or less) and built again. Now the profiler starts > up in JDK10! Thank you Jan! > > I'll go through the test spec again under JDK10 to see if anything pops up. > > P.S. what I did: > > git remote add jlahoda https://github.com/jlahoda/incubator-netbeans.git > git fetch jlahoda NETBEANS-539 > git checkout jlahoda/NETBEANS-539 > > It worked, but put me in detached head state. Not a git expert... should > the last command have been like this? > git checkout -b <new-branch-name> jlahoda/NETBEANS-539 > > -- > Glenn Holmer (Linux registered user #16682) > "After the vintage season came the aftermath -- and Cenbe." > > --------------------------------------------------------------------- > To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org > For additional commands, e-mail: netcat-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >
