Sure. I'll spend sometime to fix the testcases.
=======================================
netcf 0.2.8: tests/test-suite.log
=======================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: test-redhat
=================
.....F.
There was 1 failure:
1) testTransforms:
tutil.c:166: redhat/schema/bridge-vlan.xml: Different values for attribute
tree/@path: /files/etc/sysconfig/network-scripts/ifcfg-eth0.42 !=
/files/etc/sysconfig/network-scripts/ifcfg-br0 (lines 10 and 10)
Expected XML:
<?xml version="1.0"?>
<forest>
<tree path="/files/etc/sysconfig/network-scripts/ifcfg-br0">
<node label="DEVICE" value="br0"/>
<node label="ONBOOT" value="yes"/>
<node label="TYPE" value="Bridge"/>
<node label="BOOTPROTO" value="dhcp"/>
<node label="STP" value="off"/>
</tree>
<tree path="/files/etc/sysconfig/network-scripts/ifcfg-eth0.42">
<node label="DEVICE" value="eth0.42"/>
<node label="VLAN" value="yes"/>
<node label="ONBOOT" value="yes"/>
<node label="BRIDGE" value="br0"/>
</tree>
</forest>
Actual XML:
<?xml version="1.0"?>
<forest>
<tree path="/files/etc/sysconfig/network-scripts/ifcfg-br0">
<node label="DEVICE" value="br0"/>
<node label="ONBOOT" value="yes"/>
<node label="TYPE" value="Bridge"/>
<node label="BOOTPROTO" value="dhcp"/>
<node label="STP" value="off"/>
</tree>
<tree path="/files/etc/sysconfig/network-scripts/ifcfg-br0">
<node label="DEVICE" value="br0"/>
<node label="PHYSDEV" value="eth0"/>
<node label="VLAN" value="yes"/>
<node label="ONBOOT" value="yes"/>
<node label="BRIDGE" value="br0"/>
</tree>
</forest>
!!!FAILURES!!!
Runs: 7 Passes: 6 Fails: 1
*Leno Hou*
E-mail : leno...@gmail.com
On Thu, Dec 8, 2016 at 4:20 AM, Laine Stump <la...@laine.org> wrote:
> On 12/02/2016 12:29 AM, Leno Hou wrote:
>
>> This patch fixes the problem as shown below.
>> * virsh dumpxml failed with vlan1292 in inactive status
>> * virt-manager failed to view vlan1292 interface details.
>> RedHat Bugzilla:#1398143
>>
>
> Applying the patch causes test-redhat to fail (run "make check", then look
> in the file tests/test-redhat.log). The specific test that fails is one
> that creates a bridge that has a vlan interface attached to it
>
> <interface type="bridge" name="br0">
> <start mode="onboot"/>
> <protocol family="ipv4">
> <dhcp/>
> </protocol>
> <bridge stp="off">
> <interface type="vlan" name="eth0.42">
> <vlan tag="42">
> <interface name="eth0"/>
> </vlan>
> </interface>
> </bridge>
> </interface>
>
> Instead of creating the files ifcfg-br0 and ifcfg-eth0.42, it thinks it
> has to create 2 files named ifcfg-br0, and messes up the contents of the
> 2nd (misnamed) file as well.
>
> Even before that's fixed, I'll try to send more comments about the
> contents of the patches, but probably won't be able to do that today
> (unless I have some time tonight). In the meantime, if the fix to the above
> problem is obvious to you (I doubt that it will be obvious to me, because I
> am truly bad at navigating xsl transforms!) and you can post a revised
> patch with a quick fix, that would be helpful.
>
> Thanks for your patience (and for tackling a problem that needs xsl fu!)
>
_______________________________________________
netcf-devel mailing list -- netcf-devel@lists.fedorahosted.org
To unsubscribe send an email to netcf-devel-le...@lists.fedorahosted.org
