On Mon, Jul 11, 2016 at 4:39 PM, David Miller <[email protected]> wrote: > > From: Soheil Hassas Yeganeh <[email protected]> > Date: Sun, 10 Jul 2016 12:51:46 -0400 > > > From: Soheil Hassas Yeganeh <[email protected]> > > > > Sergei Trofimovich reported that pulse audio sends SCM_CREDENTIALS > > as a control message to TCP. Since __sock_cmsg_send does not > > support SCM_RIGHTS and SCM_CREDENTIALS, it returns an error and > > hence breaks pulse audio over TCP. > > > > SCM_RIGHTS and SCM_CREDENTIALS are sent on the SOL_SOCKET layer > > but they semantically belong to SOL_UNIX. Since all > > cmsg-processing functions including sock_cmsg_send ignore control > > messages of other layers, it is best to ignore SCM_RIGHTS > > and SCM_CREDENTIALS for consistency (and also for fixing pulse > > audio over TCP). > > > > Signed-off-by: Soheil Hassas Yeganeh <[email protected]> > > Reported-by: Sergei Trofimovich <[email protected]> > > Tested-by: Sergei Trofimovich <[email protected]> > > Please resubmit this with a proper "Fixes: " tag which tells which > commit introduced this regression.
Sorry David that I forgot the Fixes tag. I just updated the patch and resubmitted. Thanks! Soheil
