On Tue, 2016-12-06 at 21:54 +0800, [email protected] wrote:
> From: Gao Feng <[email protected]>
>
> There is no one which may reference the ipvlan port when free it in
> ipvlan_port_create and ipvlan_port_destroy. So it is unnecessary to
> use kfree_rcu.
You did not really explain _why_ it was safe/unnecessary.
Why should anyone trust you ?
The reason an RCU grace period is not needed is that
netdev_rx_handler_unregister() already enforces a grace period.
My guess is ipvlan copied code in macvlan.
At the time macvlan was written, commit
00cfec37484761a44 ("net: add a synchronize_net() in
netdev_rx_handler_unregister()") was not there yet.
macvlan could be changed the same way.
