On Tue, 2017-10-03 at 15:37 -0700, Alexei Starovoitov wrote: > - bpf prog_array just like all other types of bpf array accepts 32-bit index. > Clarify that in the comment. > - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 > bytes > - tighten corresponding check in the interpreter to stay consistent > > The JIT bug can be triggered after introduction of BPF_F_NUMA_NODE flag > in commit 96eabe7a40aa in 4.14. Before that the map_flags would stay zero and > though JIT code is wrong it will check bounds correctly. > Hence two fixes tags. All other JITs don't have this problem. > > Signed-off-by: Alexei Starovoitov <[email protected]> > Fixes: 96eabe7a40aa ("bpf: Allow selecting numa node during map creation") > Fixes: b52f00e6a715 ("x86: bpf_jit: implement bpf_tail_call() helper") > Acked-by: Daniel Borkmann <[email protected]> > Acked-by: Martin KaFai Lau <[email protected]> > --- > Backport to stable would be nice, but not strictly necessary.
Reviewed-by: Eric Dumazet <[email protected]> Thanks !
