On 18-01-11 10:07 AM, Jiri Pirko wrote:
Thu, Jan 11, 2018 at 03:46:09PM CET, [email protected] wrote:
On 18-01-11 09:41 AM, Jiri Pirko wrote:
Thu, Jan 11, 2018 at 03:37:08PM CET, [email protected] wrote:
I only looked at the kernel code. Good you can stop it at tc
but the API does not stop it (unless you expect the rest of the
world to only use tc).
Jamal, apparently, you did not looked at the kernel code either :)
Look at the changes done in net/sched/sch_ingress.c - there is where the
parsing of block attr takes place.
reason i raised it is from looking at tc_ctl_tfilter().
If i specify ifindex != TCM_IFINDEX_MAGIC_BLOCK,
parent = 0XFFFF.... and block = 22 that should work, no?
i.e regardless of whether parent is INGRESS etc.
And so i was confused why you had attributes in sch_ingress.c
Really - there is no reason for this API to be only via ingress qdisc
attributes. You can add a check in cls api to reject any parent that is
not either of the clsacts + ingress (depending on tc doesnt sound
right).
I was thinking to take this direction originally. To have another
generic attr called TCA_BLOCK or something that would be used when qdisc
is created. For ingress, what would work. But for clsact, you need to be
able to specify 2 block during qdisc creation - one for ingress, one for
egress. That's when I realized this has to be per-qdisc-type attr.
ok for clsact - i can see that we dont have enough fields in the tcm
message.
TCA_BLOCK sounds appealing - could be a speacial tlv with many block ids
maybe? I really would like to use this for egress as well - and what
i described earlier should work for me.
cheers,
jamal
