From: Guillaume Nault <[email protected]>
Date: Wed, 10 Jan 2018 16:24:45 +0100
> ppp_dev_uninit(), which is the .ndo_uninit() handler of PPP devices,
> needs to lock pn->all_ppp_mutex. Therefore we mustn't call
> register_netdevice() with pn->all_ppp_mutex already locked, or we'd
> deadlock in case register_netdevice() fails and calls .ndo_uninit().
>
> Fortunately, we can unlock pn->all_ppp_mutex before calling
> register_netdevice(). This lock protects pn->units_idr, which isn't
> used in the device registration process.
>
> However, keeping pn->all_ppp_mutex locked during device registration
> did ensure that no device in transient state would be published in
> pn->units_idr. In practice, unlocking it before calling
> register_netdevice() doesn't change this property: ppp_unit_register()
> is called with 'ppp_mutex' locked and all searches done in
> pn->units_idr hold this lock too.
>
> Fixes: 8cb775bc0a34 ("ppp: fix device unregistration upon netns deletion")
> Reported-and-tested-by: [email protected]
> Signed-off-by: Guillaume Nault <[email protected]>
Applied and queued up for -stable, thank you.
