On Wed, 14 Apr 2021 17:30:03 -0700 Tony Nguyen wrote:
> +static void ice_tx_dim_work(struct work_struct *work)
> +{
> + struct ice_ring_container *rc;
> + struct ice_q_vector *q_vector;
> + struct dim *dim;
> + u16 itr, intrl;
> +
> + dim = container_of(work, struct dim, work);
> + rc = container_of(dim, struct ice_ring_container, dim);
> + q_vector = container_of(rc, struct ice_q_vector, tx);
> +
> + if (dim->profile_ix >= ARRAY_SIZE(tx_profile))
> + dim->profile_ix = ARRAY_SIZE(tx_profile) - 1;
> +
> + /* look up the values in our local table */
> + itr = tx_profile[dim->profile_ix].itr;
> + intrl = tx_profile[dim->profile_ix].intrl;
> +
> + ice_write_itr(rc, itr);
> + ice_write_intrl(q_vector, intrl);
> +
> + dim->state = DIM_START_MEASURE;
Are you only doing register writes in ice_write_itr/intrl or talk to FW?
Scheduler is expensive so you can save real cycles if you don't have to
rely on a work to do the programming (not sure how hard that is with
DIM, but since you're already sorta poking at the internals I thought
I'd ask).