Re: [patch 2/7] [IPV4]: Consistency and whitespace cleanup of ip_rcv()

[Andi Kleen]

On Sat, Aug 20, 2005 at 03:14:15AM +0200, Thomas Graf wrote:
> +     len = ntohs(iph->tot_len);
> +     if (skb->len < len || len < (iph->ihl*4))
> +             goto inhdr_error;

If you rewrite it to something like

        u32 minlen = skb->len;
        if (minlen < iph->ihl*4)
                minlen = iph->ihl*4;
        if (skb->len < minlen) 
                goto inhdr_error

then gcc can likely generate cmov and avoid a branch

-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html