On 9/6/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> On Tue, Sep 06, 2005 at 12:21:05PM +0400, Alexey Dobriyan wrote:
> > * add svc_getnl():
> > Take network-endian value from buffer, convert to host-endian
> > one and return it.
> > * add svc_putnl():
> > Take host-endian value, convert to network-endian one and put
> > it into a buffer.
> > * convert to svc_getnl(), svc_putnl().
>
> ACK, but since we have it inlined anyway I would suggest switching most
> of remaining svc_putu32() to svc_putnl(). Stuff like svc_putu32(xdr_one)
> can become svc_putnl(1) and cc will handle that just fine.
>
> I'm still not too happy about the names, though - almost to the point
> where I'd seriously consider something like
> svc_encode_u32()/svc_decode_u32().
Or even reuse svc_{put,get}u32() by plugging htonl() and ntohl() into them.
svc_putu32(xdr_one) => svc_putu32(1)...
> At least that would be more in line with the rest of XDR-related
> marshalling
> code...
I'm quite far away from my Linux box right now, so give me a
couple of days if you want a patch.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
