John W. Linville wrote:
From: John W. Linville <[EMAIL PROTECTED]>

At least some versions of the via-velocity hardware only support
checksumming IPv4 frames in hardware.  However, the driver is currently
setting the NETIF_F_HW_CSUM flag, which indicates support for more than
just IPv4.  This results in errors when trying to use IPv6 over
via-velocity hardware.

Signed-off-by: John W. Linville <[EMAIL PROTECTED]>

---

This could be applied to the 'upstream-fixes' branch of netdev-2.6.

 drivers/net/via-velocity.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: 75f680b437862b125cbce00709fcebf57f146b88
ff8c346c43e93afc171788123c77fb5624f61153
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 82c6b75..c2d5907 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -791,7 +791,7 @@ static int __devinit velocity_found1(str
 #endif
if (vptr->flags & VELOCITY_FLAGS_TX_CSUM) {
-               dev->features |= NETIF_F_HW_CSUM;
+               dev->features |= NETIF_F_IP_CSUM;

IP_CSUM means something different than simply "ipv4-only". It also means that the hardware is quite dumb, and can only say "checksum ok" rather than "here is the checksum."

Since IP_CSUM means the latter, surely you need more code than just this?

        Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to