From: Benoit Boissinot <[EMAIL PROTECTED]>
Date: Mon, 12 Dec 2005 14:04:18 +0100

> the 'return unlikely(-err)' isn't in gitweb
> (http://kernel.org/git/?p=linux/kernel/git/davem/net-2.6.16.git;a=commit;h=eaa9fba6511857dd2dc6f7f99a4564148c238081)
> changing it to 'return -err' makes ping and xdm happy again.
> (i don't understand how the unlikely can make a performance difference).

Yes, I removed this while rebasing the tree.

> Anyway, since i'm using gcc-4 (tested with 4.0.2 and 4.1-beta) maybe it
> is a gcc bug.  I'm currently rebuilding my kernel with gcc-3.4.

Thanks for testing, good to know it's fixed now.

I think that unlikely() in the return statement was just a brain
fart on Ben's part. :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to