On Thu, 2006-05-01 at 16:39 -0800, David S. Miller wrote:
> From: Devanshu Mehta <[EMAIL PROTECTED]>
> Date: Tue, 03 Jan 2006 13:58:09 -0500
>
> > From f_u32.c:
> >
> > if (strcmp(*argv, "priority") == 0) {
> > NEXT_ARG();
> > res = parse_u8(&argc, &argv, sel, 0, 0);
> > goto done;
> > }
> ...
> > I believe, the code above should actually read:
> >
> > if (strcmp(*argv, "priority") == 0) {
> > NEXT_ARG();
> > res = parse_u8(&argc, &argv, sel, 4, 0);
> > goto done;
> > }
> >
> > though I may be mistaken as to the actual syntax of parse_u8().
>
> That looks about right to me. Did you do testing with this
> fix made?
>
> Jamal/Thomas/Stephen?
>
It is correct.
However, to be even more correct "priority" is the wrong term to use -
perhaps "class" would be a better description if insistance on keeping
it as 8 bits? But even that is inaccurate - per RFC 2474 section 3 there
is no longer a field called traffic class, rather 6 bits DSCP field and
2 bits tagged as unused which have since been allocated for ECN.
So a nicer patch would perhaps change the suggested patch to be "class"
then introduce some new english wrapper to u32 so one can specify
the dscp directly without having to compute hex masks i.e along the
lines of:
tc filter add dev eth2.1070 parent 10: protocol ipv6 prio 1 u32 match
ip6 dscp 64 flowid 10:1
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
