Jamal Hadi Salim wrote:
Maybe no need to worry about both situations for now, i will resubmit
the patch without worrying about NET_XMIT_DROP.
Looking at it again, I think you should not change the existing return
code but just use NET_XMIT_BYPASS for the TC_ACT_SHOT (TC_POLICE_SHOT)
case. Otherwise you will also return it if the packet couldn't be
classified or for other errors.
But imagine that mirred action is applied to a device at the moment when
the device is down you want the reaction to that to be different
from when mirred steals the packet because the device is up. I think at
some point a big surgery on the return path and associated error path is
needed.
Handling that would be possible now by returning something other than
TC_ACT_STOLEN from the mirred action, no?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
