On Fri, Jan 13, 2006 at 08:17:49PM +0900, Kazunori Miyazawa wrote: > > Anyway this is for 2.6.15. please review and apply it. > > Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
Thanks for the patch Miyazawa-san! Just a quick thought: HMAC is a bit of a misfit in the crypto directory. It's neither core code (cipher/digest/compress) nor your average crypto algorithm. The new XCBC seems to make pretty good company for HMAC :) Actually, they're both really digest algorithms that take a parameter. The parameter for HMAC happens to be another digest algorithm while the parameter for XCBC is an encryption algorithm. So longer term I'd like to see both written as proper digest algorithms. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
