On Mon, 16 Jan 2006, cxzhang wrote: > +++ linux-2.6.15-mm3-cxzhang/net/key/af_key.c 2006-01-13 18:41:02.000000000 > -0500 > @@ -1454,6 +1454,9 @@ static int pfkey_delete(struct sock *sk, > if (x == NULL) > return -ESRCH; > > + if ((err = security_xfrm_state_delete(x))) > + return err; > +
Missing xfrm_state_put(). > @@ -2273,6 +2276,8 @@ static int pfkey_spddelete(struct sock * > > err = 0; > > + if ((err = security_xfrm_policy_delete(xp))) > + return err; Missing xfrm_pol_put(). In these cases, use a goto so you have a single cleanup path. > +++ linux-2.6.15-mm3-cxzhang/net/xfrm/xfrm_user.c 2006-01-13 > 18:44:27.000000000 -0500 > @@ -370,6 +370,9 @@ static int xfrm_del_sa(struct sk_buff *s > if (x == NULL) > return -ESRCH; > > + if (err = security_xfrm_state_delete(x)) > + return err; > + Missing xfrm_state_put(). - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
