From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Wed, 8 Feb 2006 16:30:04 -0800 (Pacific Standard Time)
> Basically it appears that code has been there for a long time (since 2.4) > and both e1000 and other drivers use it. If the change to > skb_copy_datagram_iovec is reverted, this method of chaining skbs > continues to work. I don't see any clear reason why it shouldn't work. I think regardless of your valid points you should fix e1000 to chain page/offset/len pairs into a single SKB because using a frag list of SKBs is very wasteful and is going to break TCP socket buffer accounting. I think there was even a thread about this side effect e1000 has on TCP recently. Please fix e1000, then I'll revert the skb_copy_datagram_iovec() change being discussed. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
