On Monday 20 February 2006 16:30, Denis Vlasenko wrote:
> On Sunday 19 February 2006 00:35, Carlos Martin wrote:
> > [PATCH] acxsm: Fix Kconfig option check
> >
> > This check never actually worked because CONFIG_ACX_{ACX,USB} are
> > tristate. With Adrian Bunk's patch to the Kconfig, this works with the
> > _BOOL hidden Kconfig options.
> > Also update error message adding that this shouldn't happen anymore.
>
> Carlos, I didn't apply Adrian's patch to my tree.
>
> I am not sure we want to support every imaginable .config.
> Realistic goal is:
> * allnoconfig must compile
> * allyesconfig must compile
> * allmodconfig must compile
Which doesn't work with your #error condition.
>
> Adrian's patch makes code more obfuscated and it still has one
> corner case (when one choice is 'y' and other is 'm')
>
> If you disagree, please explain why do you want Adrian's patch
> applied.
It at least compiles. Your tree doesn't compile. It always tells me that I
didn't choose either USB or PCI support which is incorrect.
I've just tested this and CONFIG_ACX_{PCI,USB} only get defined if they are
set to Y. If they're set to M, it doesn't, so it spews out the warning.
I don't like Adrian's patch, and I don't think it's the right way to do it,
but it's what we have that works. I'll try to think of something a bit more
elegant meanwhile.
cmn
--
Carlos Martín Nieto | http://www.cmartin.tk
Hobbyist programmer |
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
