On Mon, 06 Mar 2006 16:57:11 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote: > > On Mon, 6 Mar 2006 22:30:59 +0100 > > Francois Romieu <[EMAIL PROTECTED]> wrote: > > > > > >>(s/osld.org/osdl.org/g) > >> > >>Stephen Hemminger <[EMAIL PROTECTED]> : > >> > >>>Redo the interupt handling of sky2 driver based on the IRQ mangement > >>>documentation. All interrupts are handled by the device0 NAPI poll > >>>routine. > >> > >>Is there something beyond smarter irq handling which would urge to > >>merge this code for 2.6.16 ? > >> > >>I would not mind some extra time to review it. > >> > > > > > > Well, the existing code hangs if it receives a large packet, ring gets, full > > or loses race with NAPI. > > Seems to me if you fix the first two, the last problem will go away? > > Patch #7 makes me much more nervous than the other patches. > Additionally, 2.6.16-rc is really down to taking one-liners now. I will resubmit a shorter sequence if you want for 2.6.16-rc? But I am committed to getting the correct new IRQ code working. So don't expect 2.6.16.X fixes to old irq code. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
