The Coverity checker spotted this inconsequent NULL checking 
(unconditionally dereferencing directly after checking for NULL
isn't a good idea).


Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

--- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/hostap/hostap_ap.c.old       
2006-03-10 19:30:08.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/net/wireless/hostap/hostap_ap.c   
2006-03-10 19:30:43.000000000 +0100
@@ -3141,7 +3141,7 @@ int hostap_add_sta(struct ap_data *ap, u
        if (ret == 1) {
                sta = ap_add_sta(ap, sta_addr);
                if (!sta)
-                       ret = -1;
+                       return -1;
                sta->flags = WLAN_STA_AUTH | WLAN_STA_ASSOC;
                sta->ap = 1;
                memset(sta->supported_rates, 0, sizeof(sta->supported_rates));

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to