On Wed, Mar 08, 2006 at 12:59:14PM +0000, Christoph Hellwig wrote:
> > + if (unlikely(status->frame_size > skb_tailroom(packet->skb) -
> > sizeof(struct ipw_rt_hdr))) {
>
> please don't spill over 80 characters.
>
> > #include <net/ieee80211.h>
> >
> > +#ifdef CONFIG_IPW2100_MONITOR
> > +#include <net/ieee80211_radiotap.h>
> > +#endif
>
> please include the header unconditionally.
>
> > +
> > #include <linux/workqueue.h>
>
> and for a followon patch please inlcude <net/*.h> after <linux/*.h>
On Wed, Mar 08, 2006 at 12:59:59PM +0000, Christoph Hellwig wrote:
> > --- a/drivers/net/wireless/ipw2100.c
> > +++ b/drivers/net/wireless/ipw2100.c
> > @@ -194,6 +194,7 @@ static struct ipw2100_fw ipw2100_firmwar
> > #endif
> >
> > #include <linux/moduleparam.h>
> > +#include <linux/mutex.h>
> > module_param(debug, int, 0444);
>
> please keep a whitespace after the includes and before the module_param
> statements.
In the interest of progress, I'm going to go ahead and merge these
patches. But, I would happily accept style patches to clean-up
these issues...anyone?
John
--
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
