> From: [email protected] [mailto:netdev- > [email protected]] On Behalf Of Alexander Duyck > Sent: Wednesday, March 2, 2016 1:16 PM > To: [email protected]; [email protected]; intel-wired- > [email protected]; Kirsher, Jeffrey T <[email protected]>; > [email protected] > Subject: [net PATCH 1/2] e1000: Do not overestimate descriptor counts in Tx > pre-check > > The current code path is capable of grossly overestimating the number of > descriptors needed to transmit a new frame. This specifically occurs if > the skb contains a number of 4K pages. The issue is that the logic for > determining the descriptors needed is ((S) >> (X)) + 1. When X is 12 it > means that we were indicating that we required 2 descriptors for each 4K > page when we only needed one. > > This change corrects this by instead adding (1 << (X)) - 1 to the S value > instead of adding 1 after the fact. This way we get an accurate descriptor > needed count as we are essentially doing a DIV_ROUNDUP(). > > Reported-by: Ivan Suzdal <[email protected]> > Signed-off-by: Alexander Duyck <[email protected]> > --- > drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Aaron Brown <[email protected]>
