On 11/03/16 19:57, Tom Herbert wrote: > On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree <ec...@solarflare.com> wrote: >> Tom, >> >> Are you planning to / working on implementing this? If not, I might have a >> crack at it; I've talked to our firmware guys and (provisionally) we think >> we can support it in current sfc hardware. >> Or were there any blocking problems raised in the thread? My understanding >> of the IP ID issue was that it only matters for the inner frame, because >> the rest aren't TCP (so hopefully no-one is doing SLHC on them). But I may >> have missed something. >> > Right, then the interface would need to just include the offset of the > IP ID. But doesn't this break using LCO with GSO though-- i.e. the > outer checksum and inner checksum still need to be updated per packet > so we need to tell device where outer checksum(s) is. No, outer checksum shouldn't change: IP ID is protected by inner IP header checksum, which device will edit. No?
-Ed
