On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote: > A recent change to the mbus driver added a warning printk that > prints a phys_addr_t using the %x format string, which fails in > case we build with 64-bit phys_addr_t:
Hey Arnd. This is a bad patch subject, %pad is for a dma_addr_t. The patch subject made me assume the patch was incorrect. > > This uses the special %pa format string instead, so we always > print the correct type. [] > - pr_err("invalid dram address 0x%x\n", phyaddr); > + pr_err("invalid dram address %pa\n", &phyaddr); The patch is good though.