On Sat, 2006-04-01 at 05:20 -0800, Linsys Contractor Amit S. Kale wrote:
> +static inline void
> +netxen_nic_reg_write (netxen_adapter *adapter, u64 off, __uint32_t val)
> +{//Only for window 1
> + void *addr;
> +
> + read_lock(&adapter->adapter_lock);
> +
> + if (adapter->curr_window != 1) {
> + netxen_nic_pci_change_crbwindow(adapter, 1);
> + }
> + addr = CRB_NORMALIZE(adapter, off);
> + DPRINTK(1, INFO, "writing to base %lx offset %llx addr %p data %x\n",
> + adapter->ahw.pci_base, off, addr, val);
> + NetXen_NIC_PCI_WRITE_32 (val, addr);
> +
> + read_unlock(&adapter->adapter_lock);
> +}
It makes no sense to be inlining routines that use rwlocks. Use
spinlocks, or else make them out of line.
<b
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
