On Mon, Apr 4, 2016 at 11:07 AM, Eric Dumazet <[email protected]> wrote: > On Mon, 2016-04-04 at 10:32 -0700, Cong Wang wrote: >> Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc >> actions") >> Reported-by: Dmitry Vyukov <[email protected]> >> Tested-by: Dmitry Vyukov <[email protected]> >> Cc: Jamal Hadi Salim <[email protected]> >> Signed-off-by: Cong Wang <[email protected]> >> --- >> include/net/act_api.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/net/act_api.h b/include/net/act_api.h >> index 2a19fe1..03e322b 100644 >> --- a/include/net/act_api.h >> +++ b/include/net/act_api.h >> @@ -135,6 +135,7 @@ void tcf_hashinfo_destroy(const struct tc_action_ops >> *ops, >> static inline void tc_action_net_exit(struct tc_action_net *tn) >> { >> tcf_hashinfo_destroy(tn->ops, tn->hinfo); >> + kfree(tn->hinfo); >> } >> >> int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb, > > Looks good to me, although the kfree() might be put in > cf_hashinfo_destroy() (at one place instead of being inlined in all call > points)
Putting it in tc_action_net_exit() makes it symmetric with tc_action_net_init().
