On Fri, Apr 8, 2016, at 16:18, Bjørn Mork wrote:
> Daniel Borkmann <dan...@iogearbox.net> writes:
> 
> >  
> >     if (!token)
> >             return -EINVAL;
> > -   if (ipv6_addr_any(token))
> > -           return -EINVAL;
> >     if (dev->flags & (IFF_LOOPBACK | IFF_NOARP))
> >             return -EINVAL;
> 
> Not directly related to the patch in question.  It just made me aware of
> this restriction...
> 
> I realize that I'm a few years late here, but what's with the IFF_NOARP?
> Is that just because we can't do DAD for the token based addresses?  How
> is that different from manually configuring the whole address?

IFF_NOARP is kind of the equivalent to no neighbor discovery. If you set
a token and never get in a router advertisement you never create a
tokenized ip address, thus the feature is useless.

Bye,
Hannes

Reply via email to