From: Stephen Hemminger <[email protected]>
Date: Tue, 19 Apr 2016 08:21:00 -0700

> On Wed, 13 Apr 2016 13:52:22 +0200
> Peter Heise <[email protected]> wrote:
> 
>> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
>> index 9427f17..bb3a90b 100644
>> --- a/include/uapi/linux/if_link.h
>> +++ b/include/uapi/linux/if_link.h
>> @@ -773,6 +773,7 @@ enum {
>>      IFLA_HSR_SLAVE1,
>>      IFLA_HSR_SLAVE2,
>>      IFLA_HSR_MULTICAST_SPEC,        /* Last byte of supervision addr */
>> +    IFLA_HSR_VERSION,               /* HSR version */
>>      IFLA_HSR_SUPERVISION_ADDR,      /* Supervision frame multicast addr */
>>      IFLA_HSR_SEQ_NR,
> 
> You added a new value into the middle of an enumeration field.
> This breaks kernel ABI. Older applications (like iproute) would see the wrong
> values.
> 
> Please submit a new change which moves HSR_VERSION to the end of the enum

Good catch, Stephen.

Reply via email to