From: Saeed Mahameed <sae...@mellanox.com>
Date: Tue, 19 Apr 2016 15:33:42 +0300
> Upon ethtool request to set speed to 0 we handle it as a special request
> to reset link modes to Device's defaults.
>
> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4
> Ethernet functionality")
> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
Please don't try to sneak things like this into the patches you submit.
If you continue to add weird stuff like this, I will never _ever_ be
able to trust you guys and have a high degree of confidence in your
changes. If you continue like this, I will always have to audit your
patches very strictly which is very time consuming for me.
Do not extend ethtool's semantics in a way which suits you specifically.
If we want to have this semantic, you must first propose it as a
global semantic which then in turn can be adopted by all drivers
supporting ethtool.
Thank you.
