Le 21/04/2016 20:28, David Miller a écrit :
From: Nicolas Dichtel <[email protected]>
Date: Thu, 21 Apr 2016 18:58:23 +0200
Here is a proposal to add more helpers in the libnetlink to manage 64-bit
alignment issues.
Note that this series was only tested on x86 by tweeking
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS and adding some traces.
The first patch adds helpers for 64bit alignment and other patches
use them.
We could also add helpers for nla_put_u64() and its variants if needed.
v1 -> v2:
- remove patch #1
- split patch #2 (now #1 and #2)
- add nla_need_padding_for_64bit()
I like it, nice work Nicolas.
Thank you.
Applied to net-next.
I did a quick scan and the following jumped out at me as cases we need
to fix up as well:
Did you grep something or just catch this by code review?
1) xfrm_user
2) tcp_info
3) taskstats
4) pkt_{cls,sched}
5) openvswitch
etc.
Most of these are statistic cases just like all of the existing ones
we have fixed so far.
Yes, I will follow on this topic. There are also a bunch of
nla_put_[u|be|le]64():
$ git grep -w "nla_put_.\{1,2\}64" net/ | wc -l
118
$ git grep -w "nla_put_.\{1,2\}64" | wc -l
172
