Re: [PATCHv2] phy: fix crash in fixed_phy_add()

[Andrew Lunn]

On Tue, May 17, 2016 at 11:01:50AM +0200, Rabin Vincent wrote:

Hi Rabin

Thanks for v2. This is a lot better

> @@ -314,6 +315,9 @@ struct phy_device *fixed_phy_register(unsigned int irq,
>       int phy_addr;
>       int ret;
>  
> +     if (!fmb->mii_bus)
> +             return ERR_PTR(-EPROBE_DEFER);

Better still:

       if (!fmb->mii_bus || fmb->mii_bus->state != MDIOBUS_REGISTERED)
                return ERR_PTR(-EPROBE_DEFER);

Thanks
        Andrew