Jeff Kirsher <[EMAIL PROTECTED]> :
[...]
> diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c
> index e8d83de..978be30 100644
> --- a/drivers/net/ixgb/ixgb_ethtool.c
> +++ b/drivers/net/ixgb/ixgb_ethtool.c
[...]
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index 6f8fd6f..f468d5d 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1227,11 +1227,11 @@ ixgb_tso(struct ixgb_adapter *adapter, s
> if(++i == adapter->tx_ring.count) i = 0;
> adapter->tx_ring.next_to_use = i;
>
> - return 1;
> + return TRUE;
> }
> #endif
>
> - return 0;
> + return FALSE;
> }
Grmbl... TRUE/FALSE
More importantly, it seems bogus. See below:
drivers/net/ixgb/ixgb_main.c::ixgb_xmit_frame
[...]
tso = ixgb_tso(adapter, skb);
if (tso < 0) {
^^^
dev_kfree_skb_any(skb);
return N
[...]
> @@ -1413,7 +1413,7 @@ ixgb_xmit_frame(struct sk_buff *skb, str
> if(unlikely(IXGB_DESC_UNUSED(&adapter->tx_ring) < DESC_NEEDED)) {
> netif_stop_queue(netdev);
> spin_unlock_irqrestore(&adapter->tx_lock, flags);
> - return 1;
> + return NETDEV_TX_BUSY;
> }
It is considered a bug. You can check for this situation on the current
skb but the driver should check if there is enough room for the *next*
packet before it leaves ixgb_xmit_frame().
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
