On 06/14/2016 09:30 PM, Sergei Shtylyov wrote:
If the interrupt configuration isn't set and we are using the internal phy, then we need to poll the phy to reliably detect phy state changes.Signed-off-by: Jeremy Linton <jeremy.lin...@arm.com> --- drivers/net/ethernet/smsc/smsc911x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index 8af2556..369dc7d 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -1020,6 +1020,9 @@ static int smsc911x_mii_probe(struct net_device *dev) return -ENODEV; } + if ((!phydev->irq) && (!pdata->using_extphy))Inner parens aren't needed at all.
Hm, 'phydev->irq' shouldn't be 0 in the first place. It seems to me we should correctly initialize 'pdata->phy_irq[]' in smsc911x_mii_init()...
MBR, Sergei
