On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote:
> We accidentally return success when we had intended to return an error
> code.
>
> Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads
> mode')
> Signed-off-by: Dan Carpenter <[email protected]>
> v2: return -ENOTSUPP instead --EINVAL
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 1842dfb..7d982cf 100644
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -183,6 +183,7 @@ static int esw_create_offloads_fdb_table(struct
> mlx5_eswitch *esw, int nvports)
>
> root_ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_FDB);
> if (!root_ns) {
> + err = -ENOTSUPP;
Did you mean ENOTSUP?
I thought ENOTSUPP was not to be used outside NFS, and isn't properly
exported to userspace..
$ find /usr/include -name "*errno*" | xargs grep 524
Jason
